Quuxplusone added inline comments.
================ Comment at: clang/unittests/Format/FormatTest.cpp:22443 + Style); +} + ---------------- Quuxplusone wrote: > I'd like to see `module :private;` > I'd like to see `import <foo/bar.h>;` > I'd like to see `import foo...bar;` > I'd like to see `import ..........;` > Is `module foo:private;` a thing? > Is `module public:while;` a thing? I don't intend to block this PR waiting on //fixing// these, but please at least add the "I'd like to see" test cases with `TODO` comments. That way, whoever tackles it will have the test cases already written. As usual, I'm ambivalent about the "Is X a thing?" test cases — they arguably don't matter but arguably should be tested anyway to make sure clang-format doesn't crash on them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114151/new/ https://reviews.llvm.org/D114151 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
