steakhal added a comment. ping
================ Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-virtual-class-destructor.cpp:288 +protected: + virtual CONCAT(~Foo, Bar2()); // no-fixit +}; ---------------- whisperity wrote: > whisperity wrote: > > It is strange that there is no fix-it here even though the keyword appears > > as a single token ...[1] > Maybe a FIXME could be added for this case, just to register that we indeed > realised something is //strange// here, but I'm not convinced neither for nor > against. The purpose of the patch is to get rid of the crash, after all. Definitely deserves a FIXME. Yes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113558/new/ https://reviews.llvm.org/D113558 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
