yaxunl added a comment.
could you please include a complete diff context in the patch? You can do that
by using git diff -U9999
================
Comment at: mlir/lib/ExecutionEngine/CMakeLists.txt:153
+ set(CMAKE_MODULE_PATH "${HIP_PATH}/lib/cmake/hip" ${CMAKE_MODULE_PATH})
find_package(HIP)
if (NOT HIP_FOUND)
----------------
mehdi_amini wrote:
> mehdi_amini wrote:
> > Is MLIR really coupled to Clang here? That seems suspicious to me.
> In particular, this makes MLIR sensitive to the version actually installed on
> the machine, which is independent from whatever clang is in the repo. This
> seems undesirable, what am I missing here?
Probably it is not depending on clang, but depending on HIP cmake file to get
HIP package to be able to use HIP header and library files for kernel launching
API.
To be compatible with all ROCm releases, probably CMAKE_MODULE_PATH should also
include the HIP cmake path for both old and new ROCm releases.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114502/new/
https://reviews.llvm.org/D114502
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
