Bigcheese added a comment.

Can we not consider a modulemap used when we load an AST that depends on that 
modulemap? It's possible this breaks if the module only includes textual 
headers though. It really feels like we should have a single place where we 
actually know if a module is used or not. Long term I would really like to 
separate modulemap parsing from `Module` creation, which would be a great place 
to actually do this.

For now we just need to make sure we report every modulemap search path that 
wouldn't change semantics if removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113676/new/

https://reviews.llvm.org/D113676

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to