peixin added a comment.

In D114413#3166979 <https://reviews.llvm.org/D114413#3166979>, @Meinersbur 
wrote:

> In D114413#3160044 <https://reviews.llvm.org/D114413#3160044>, @peixin wrote:
>
>> In D114413#3159095 <https://reviews.llvm.org/D114413#3159095>, @Meinersbur 
>> wrote:
>>
>>> In D114413#3154936 <https://reviews.llvm.org/D114413#3154936>, @peixin 
>>> wrote:
>>>
>>>> 
>>
>> `getPreheader()` was in `OMPIRBuilder.cpp` before you rebase in your last 
>> update here. That's why I let you rebase since I failed to git apply your 
>> last patch in main branch. It's not important now. Please forget about that.
>
> D114368 <https://reviews.llvm.org/D114368> (which this patch depends on) 
> moves `getPreheder()` to the `.cpp` files (because it has become more than a 
> simple getter)

Thanks a lot. Now I get it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114413/new/

https://reviews.llvm.org/D114413

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to