curdeius added inline comments.
================ Comment at: clang/lib/Format/Format.cpp:2597 + // or we will sort the contents of the string. + // Skip past until we think we we the rawstring literal close. + if (Trimmed.contains("R\"(")) { ---------------- "we we"? ================ Comment at: clang/lib/Format/Format.cpp:2598 + // Skip past until we think we we the rawstring literal close. + if (Trimmed.contains("R\"(")) { + FormattingOff = true; ---------------- This won't be enough for raw literals with custom delimiter e.g. `R"xyz(...)xyz"`. But well, without any code parsing, this function will always be easily outsmarted I guess. Maybe we can use regexp here and save the delimiter? (And then check it below) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115168/new/ https://reviews.llvm.org/D115168 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits