Guess this is untestable right now, since it's overriding with the same value? Maybe worth adding an explicit test for the PS4 default - so that the test would fail /if/ the generic (non-PS4) default was changed (which we'll hopefully change in the near future)?
On Tue, Nov 30, 2021 at 8:59 AM Paul Robinson via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Paul Robinson > Date: 2021-11-30T08:58:40-08:00 > New Revision: b8e03be88dc87303f7401ea7b9906947ac67a6db > > URL: > https://github.com/llvm/llvm-project/commit/b8e03be88dc87303f7401ea7b9906947ac67a6db > DIFF: > https://github.com/llvm/llvm-project/commit/b8e03be88dc87303f7401ea7b9906947ac67a6db.diff > > LOG: [PS4][DWARF] Explicitly set default DWARF version to 4 > > Added: > > > Modified: > clang/lib/Driver/ToolChains/PS4CPU.h > > Removed: > > > > > ################################################################################ > diff --git a/clang/lib/Driver/ToolChains/PS4CPU.h > b/clang/lib/Driver/ToolChains/PS4CPU.h > index 82f9523f84fb8..4bedabaf267c0 100644 > --- a/clang/lib/Driver/ToolChains/PS4CPU.h > +++ b/clang/lib/Driver/ToolChains/PS4CPU.h > @@ -80,6 +80,7 @@ class LLVM_LIBRARY_VISIBILITY PS4CPU : public > Generic_ELF { > return LangOptions::SSPStrong; > } > > + unsigned GetDefaultDwarfVersion() const override { return 4; } > llvm::DebuggerKind getDefaultDebuggerTuning() const override { > return llvm::DebuggerKind::SCE; > } > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits