dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land.
LGTM, except I'd prefer the `#include`s be changed separately since that cleanup seems unrelated to this change. ================ Comment at: lldb/unittests/Expression/CppModuleConfigurationTest.cpp:14 #include "lldb/Host/HostInfo.h" -#include "llvm/Support/SmallVectorMemoryBuffer.h" ---------------- Please clean up the includes in a prep commit (no need for review IMO) rather than a drive-by. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115331/new/ https://reviews.llvm.org/D115331 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
