kuhnel added a comment. In D113898#3167215 <https://reviews.llvm.org/D113898#3167215>, @kbobyrev wrote:
> In D113898#3167050 <https://reviews.llvm.org/D113898#3167050>, @kuhnel wrote: > >> Looking at the documentation, this looks like a bug in the clang-tidy check: >> https://releases.llvm.org/13.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability-qualified-auto.html >> >> The rule `llvm-qualified-auto` should not add a `const` qualifier. > > I don't see how that is a bug: the docs specially cover the `const auto *` > conversion in the first example by drawing the line between `observe()` > (non-mutating function) and `change()` (possibly mutating function). Sorry I should have been more precise here: `AddConstToQualified` allows to configure if we want to have `const` added or not. The default for that rule is `true`. However the last sentence on that page says: > Note in the LLVM alias, the default value is false. So my understanding of this is: With the LLVM-rules we're using, `const` should not be added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113898/new/ https://reviews.llvm.org/D113898 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
