salman-javed-nz added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/llvm/HeaderGuardCheck.cpp:57 std::replace(Guard.begin(), Guard.end(), '-', '_'); + std::replace(Guard.begin(), Guard.end(), ':', '_'); ---------------- salman-javed-nz wrote: > Are there other characters we should be sanitising here? > (Lest keep revisiting this code to add more characters to the list) Typo: *Lest **we** keep revisiting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115715/new/ https://reviews.llvm.org/D115715 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits