owenpan added a comment.
Thanks for factoring the code.
================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1872
// calling `addUnwrappedLine()` here causes odd parsing errors.
FormatTok->MustBreakBefore = true;
}
----------------
MyDeveloperDay wrote:
> part of me thinks the MustBreakBefore should be handled separately in
> TokenAnnotator::mustBreakBefore() and let it do its stuff.
Yes, but we can take care of it in a separate patch.
================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1859
+ nextToken();
+ if (FormatTok->is(tok::l_brace)) {
+ // C# may break after => if the next character is a newline.
----------------
Early return.
================
Comment at: clang/lib/Format/UnwrappedLineParser.h:141
bool tryToParseLambda();
+ bool tryParseCSharpLambda();
bool tryToParseLambdaIntroducer();
----------------
To keep the naming consistent.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115738/new/
https://reviews.llvm.org/D115738
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
