serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments.
================ Comment at: llvm/include/llvm/IR/Attributes.h:993 + + bool empty() const { return Attrs.none(); } + bool hasAttributes() const { return TargetDepAttrs.empty() && Attrs.none(); } ---------------- nikic wrote: > Should this check TargetDepAttrs as well? I matched the implementation in AttrBuilder, which looks odd to me too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/ https://reviews.llvm.org/D116110 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits