SjoerdMeijer added reviewers: dmgreen, SjoerdMeijer.
SjoerdMeijer added inline comments.
================
Comment at: clang/lib/Basic/Targets/ARM.cpp:937
case llvm::ARM::ArchKind::ARMV9_2A:
getTargetDefinesARMV83A(Opts, Builder);
break;
----------------
Perhaps unrelated to this patch, but I am surprised to see that from v 8.3 and
up we only include `getTargetDefinesARMV83A`, so no other target defines were
introduced or are necessary? This is not rhetorical question....I haven't paid
attention to this since v8.4.
================
Comment at: clang/test/Preprocessor/aarch64-target-features.c:296
// RUN: %clang -target x86_64-apple-macosx -arch arm64 -### -c %s 2>&1 |
FileCheck --check-prefix=CHECK-ARCH-ARM64 %s
+// CHECK-ARCH-ARM64: "-target-cpu" "apple-m1" "-target-feature" "+v8.5a"
"-target-feature" "+fp-armv8" "-target-feature" "+neon" "-target-feature"
"+crc" "-target-feature" "+crypto" "-target-feature" "+dotprod"
"-target-feature" "+fp16fml" "-target-feature" "+ras" "-target-feature" "+lse"
"-target-feature" "+rdm" "-target-feature" "+rcpc" "-target-feature" "+zcm"
"-target-feature" "+zcz" "-target-feature" "+fullfp16" "-target-feature" "+sm4"
"-target-feature" "+sha3" "-target-feature" "+sha2" "-target-feature" "+aes"
----------------
I don't pretend to understand the combo `x86_64-apple-macosx -arch arm64`
here.... but is unrelated to this patch...
================
Comment at: clang/test/Preprocessor/aarch64-target-features.c:298
+// CHECK-ARCH-ARM64: "-target-cpu" "apple-m1" "-target-feature" "+v8.5a"
"-target-feature" "+fp-armv8" "-target-feature" "+neon" "-target-feature"
"+crc" "-target-feature" "+crypto" "-target-feature" "+dotprod"
"-target-feature" "+fp16fml" "-target-feature" "+ras" "-target-feature" "+lse"
"-target-feature" "+rdm" "-target-feature" "+rcpc" "-target-feature" "+zcm"
"-target-feature" "+zcz" "-target-feature" "+fullfp16" "-target-feature" "+sm4"
"-target-feature" "+sha3" "-target-feature" "+sha2" "-target-feature" "+aes"
// RUN: %clang -target x86_64-apple-macosx -arch arm64_32 -### -c %s 2>&1 |
FileCheck --check-prefix=CHECK-ARCH-ARM64_32 %s
----------------
A test for v8.5 seems to be covered above somehow, but do we not need any tests
for v8.6 and v 8.7?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116153/new/
https://reviews.llvm.org/D116153
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
