pbarrio requested changes to this revision.
pbarrio added a comment.
This revision now requires changes to proceed.
Suggest clarifying the commit message to something like:
"Added warning for potential cases of unaligned access when option
-mno-unaligned-access has been specified".
Nice testing :)
================
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:463-464
options::OPT_munaligned_access)) {
if (A->getOption().matches(options::OPT_mno_unaligned_access))
+ {
Features.push_back("+strict-align");
----------------
Nit: preserve coding style of the file. Move the bracket to the previous line,
preceded by a space. I.e.
if (A->getOption().matches(options::OPT_mno_unaligned_access)) {
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116221/new/
https://reviews.llvm.org/D116221
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
