zwliew added a comment.

On further thought, the logic for `loadConfigFile()` looks incomplete. It does 
not properly handle the `InheritParentConfig` argument for `BasedOnStyle`. In 
fact, `loadConfigFile()` should probably use the same logic as that for 
`-style=file`. I can look into making this change, and possibly refactoring the 
code to reduce code duplication.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72326/new/

https://reviews.llvm.org/D72326

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to