aaron.ballman added inline comments.
================
Comment at:
clang-tools-extra/test/clang-tidy/checkers/misc-unused-parameters.cpp:157-159
// CHECK-FIXES: C() {}
C(int i) {}
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning
----------------
I think this fix is incorrect and should not be applied; it changes the meaning
of the interface from having a converting constructor to having a default
constructor. I think that needs to be optional behavior because it's a pretty
invasive change to apply automatically. This patch builds on top of the
existing incorrect behavior, but would be fine if it was only applied when the
option to modify constructors is enabled.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116513/new/
https://reviews.llvm.org/D116513
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
