sbenza added inline comments.

================
Comment at: clang-tidy/misc/MisplacedConstCheck.cpp:22
@@ +21,3 @@
+  Finder->addMatcher(
+      valueDecl(allOf(hasType(isConstQualified()),
+                      hasType(typedefType(hasDeclaration(
----------------
allOf() is unnecessary

================
Comment at: clang-tidy/misc/MisplacedConstCheck.cpp:26
@@ +25,3 @@
+                                          isConstQualified(),
+                                          ignoringParens(functionType())))))))
+                              .bind("typedef"))))))
----------------
Should we ignore pointer to members?
If not, we should add a test for those.


http://reviews.llvm.org/D21036



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to