jyknight accepted this revision.
jyknight added a comment.

Accepting assuming the last comment will be addressed before pushing. Thanks!



================
Comment at: clang/lib/Frontend/InitPreprocessor.cpp:257
+  if (IsSigned)
+    DefineTypeSizeAndWidth("__INT" + Twine(TypeWidth), Ty, TI, Builder);
+  else
----------------
DefineTypeSizeAndWidth isn't necessary from DefineExactWidthIntTypeSize, since 
`__INT#_WIDTH__ == #` always, so there's no point in emitting `#define 
__INT8_WIDTH__ 8`, etc.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115253/new/

https://reviews.llvm.org/D115253

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to