erichkeane added inline comments.
================ Comment at: clang/test/Preprocessor/init.c:1523 // WEBASSEMBLY-NEXT:#define __BIGGEST_ALIGNMENT__ 16 +// WEBASSEMBLY-NEXT:#define __BITINT_MAXWIDTH__ 8388608 // WEBASSEMBLY-NEXT:#define __BOOL_WIDTH__ 8 ---------------- Actually.... why are we testing WEBASSEMBLY/AArch64 only? I get that these two both do a 'next', but I would presume we'd want a similar test that ends up being for ALL platforms. Its unfortunate the way that this test is setup, but could we perhaps have a 'triple-less' (or a test that just has a massive number of triples?) test of some sort that just validates this value? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117238/new/ https://reviews.llvm.org/D117238 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
