belkiss added inline comments.

================
Comment at: 
compiler-rt/test/ubsan/TestCases/TypeCheck/global-new-alignment.cpp:33
+int main() {
+  // CHECK-NOT: runtime error: constructor call on misaligned address 
[[PTR:0x[0-9a-f]*]] for type 'Param', which requires 16 byte alignment
+  Param *p = new Param;
----------------
rnk wrote:
> I suggest simplifying this to `CHECK-NOT: runtime error`, since no errors are 
> expected. This is mostly to improve test debuggability anyway, the test will 
> fail if it exits non-zero.
I'll remove it altogether from here, since I pass 
`--implicit-check-not="runtime error"` to the FileCheck at the top of the file


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116861/new/

https://reviews.llvm.org/D116861

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to