sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/Selection.cpp:758
+ // ranges of children are not overlapped with their parent's.
+ // But there are some AST-weird cases, e.g.
+ // auto fun = [bar = foo]() { ... }
----------------
I don't think this is an e.g., but rather is suitable for specifically this
case.
If there are other cases, we likely should be testing DeclaratorDecl here, and
excluding Constructor/Destructor as before.
================
Comment at: clang-tools-extra/clangd/Selection.cpp:773
void claimTokensFor(const DynTypedNode &N, SelectionTree::Selection &Result)
{
// CXXConstructExpr often shows implicit construction, like `string s;`.
// Don't associate any tokens with it unless there's some syntax like {}.
----------------
I wonder whether we want to keep the CXXConstructExpr hack now, up to you.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117472/new/
https://reviews.llvm.org/D117472
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
