craig.topper added inline comments.

================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZb.td:907
           (FSR GPR:$rs1, GPR:$rs2, GPR:$rs3)>;
+def : Pat<(riscv_fsr GPR:$rs3, GPR:$rs1, uimmlog2xlen:$shamt),
+          (FSRI GPR:$rs1, GPR:$rs3, uimmlog2xlen:$shamt)>;
----------------
Chenbing.Zheng wrote:
> craig.topper wrote:
> > Need to also handle fsl with a constant argument.
> Emm.... but there is no fsli in zbt. 
Yes because the compiler can change the constant to turn fsli into fsri. We do 
this on line 903.

If the user uses fsl with a constant we should give them good code by turning 
it into fsri.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117468/new/

https://reviews.llvm.org/D117468

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to