Author: Stanislav Gatev Date: 2022-01-18T15:16:44Z New Revision: d7c19f947e0c93369e71404c33db836e3b6ac3f7
URL: https://github.com/llvm/llvm-project/commit/d7c19f947e0c93369e71404c33db836e3b6ac3f7 DIFF: https://github.com/llvm/llvm-project/commit/d7c19f947e0c93369e71404c33db836e3b6ac3f7.diff LOG: [clang][dataflow] Remove obsolete FIXME The FIXME is no longer relevant as ControlFlowContext centralizes the construction of the CFG. This is part of the implementation of the dataflow analysis framework. See "[RFC] A dataflow analysis framework for Clang AST" on cfe-dev. Reviewed-by: xazax.hun Differential Revision: https://reviews.llvm.org/D117563 Added: Modified: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp Removed: ################################################################################ diff --git a/clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp b/clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp index 722b24f5b9718..538cdce206b2f 100644 --- a/clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp +++ b/clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp @@ -191,10 +191,6 @@ std::vector<llvm::Optional<TypeErasedDataflowAnalysisState>> runTypeErasedDataflowAnalysis(const ControlFlowContext &CFCtx, TypeErasedDataflowAnalysis &Analysis, const Environment &InitEnv) { - // FIXME: Consider enforcing that `Cfg` meets the requirements that - // are specified in the header. This could be done by remembering - // what options were used to build `Cfg` and asserting on them here. - PostOrderCFGView POV(&CFCtx.getCFG()); ForwardDataflowWorklist Worklist(CFCtx.getCFG(), &POV); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
