aaron.ballman added a comment. In D117129#3246403 <https://reviews.llvm.org/D117129#3246403>, @njames93 wrote:
> In D117129#3239514 <https://reviews.llvm.org/D117129#3239514>, > @LegalizeAdulthood wrote: > >> In D117129#3239143 <https://reviews.llvm.org/D117129#3239143>, @njames93 >> wrote: >> >>> My proposed idea was putting the `IncludeInserter` instance >>> inside the `ClangTidyContext`, but then only registering it if >>> any checks actually want to use it. >> >> Use of the `IncludeInserter` would be signaled by an argument >> to the ctor fo r`ClangTidyCheck` in the c'tor for the derived >> class? > > There is a hurdle to overcome with this, Currently each check can have its > own include style - which doesn't really make sense. Hmm, I think it could make sense for sizeable projects that have components written by separate teams. Granted, I think it's a bit of a strange situation, but I wouldn't go so far as to say it doesn't make sense. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117129/new/ https://reviews.llvm.org/D117129 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
