atmnpatel added inline comments.
================
Comment at: openmp/libomptarget/DeviceRTL/CMakeLists.txt:231
+
+compileDeviceRTLLibrary(x86_64 vgpu -target x86_64-vgpu -std=c++20
-stdlib=libc++ -I${devicertl_base_directory}/../plugins/vgpu/src)
----------------
tianshilei1992 wrote:
> It's not a good practice to specify include directories in CMake in this way.
> Use `include_directories` instead.
can't quite do that here I think, afaik both `include_directories` and
`target_include_directories` require that CMake builds the target, but we
specify custom targets/build commands so they don't get pulled in
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113359/new/
https://reviews.llvm.org/D113359
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
