mstorsjo added a comment.

In D111081#3212890 <https://reviews.llvm.org/D111081#3212890>, @mgorny wrote:

> Well, I dunno how MinGW works, so can't judge that part. Furthermore, I'm 
> thoroughly confused why this works on top of existing (non-Gentoo?) test 
> tree. Could you explain it a bit more?

It looks like the clang driver just blindly adds these directories to the list 
of include paths, regardless of whether they exist or not. So with the current 
test, they don't need to exist (but maybe it would be good to create such empty 
directories to make the test a bit more correct, in case the driver is modified 
to not add nonexistent directories blindly).

FYI @maharmstone the test needs to be rebased to fit on top of current git, 
after rG897c86dec5af2780d443edd852aa5911e2650ec6 
<https://reviews.llvm.org/rG897c86dec5af2780d443edd852aa5911e2650ec6>.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111081/new/

https://reviews.llvm.org/D111081

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to