craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang/test/Preprocessor/riscv-target-features.c:221
// RUN: -o - | FileCheck --check-prefix=CHECK-V-EXT %s
-// CHECK-V-EXT: __riscv_v 10000
+// CHECK-V-EXT: __riscv_v 1000000
// CHECK-V-EXT: __riscv_vector 1
----------------
Does this line pass even if you don't change it since we don't match to the end
of the line? I might suggest we go through this file and put `{{{$}}` on the
end of lines, but that can be a separate change. Or we add the `#define` to
each line and pass --match-full-lines to FileCheck.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112987/new/
https://reviews.llvm.org/D112987
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
