Author: Alexandre Ganea Date: 2022-01-20T14:11:10-05:00 New Revision: 5fa4cf82dfa075e7983ce92d0042480b7b8f4fbc
URL: https://github.com/llvm/llvm-project/commit/5fa4cf82dfa075e7983ce92d0042480b7b8f4fbc DIFF: https://github.com/llvm/llvm-project/commit/5fa4cf82dfa075e7983ce92d0042480b7b8f4fbc.diff LOG: [Clang] Separate the 'debug-info-hotpatch' test in two parts: one for ARM and another for AArch64 After 5af2433e1794ebf7e58e848aa612c7912d71dc78, this shall fix: https://lab.llvm.org/buildbot/#/builders/188/builds/8400 - if not I'll revert this patch and 5af2433e1794ebf7e58e848aa612c7912d71dc78. Added: clang/test/CodeGenCXX/debug-info-hotpatch-aarch64.cpp Modified: clang/test/CodeGenCXX/debug-info-hotpatch-arm.cpp Removed: ################################################################################ diff --git a/clang/test/CodeGenCXX/debug-info-hotpatch-aarch64.cpp b/clang/test/CodeGenCXX/debug-info-hotpatch-aarch64.cpp new file mode 100644 index 000000000000..10fb1750f2c5 --- /dev/null +++ b/clang/test/CodeGenCXX/debug-info-hotpatch-aarch64.cpp @@ -0,0 +1,23 @@ +// REQUIRES: aarch64-registered-target +/// +/// Check that using /hotpatch doesn't generate an error. +/// Binaries are always hotpatchable on ARM/ARM64. +/// +// RUN: %clang_cl --target=aarch64-pc-windows-msvc /c /hotpatch /Z7 -- %s 2>&1 +/// +/// Ensure that we set the hotpatchable flag in the debug information. +/// +// RUN: %clang_cl --target=aarch64-pc-windows-msvc /c /Z7 -o %t.obj -- %s +// RUN: llvm-pdbutil dump -symbols %t.obj | FileCheck %s --check-prefix=HOTPATCH +// HOTPATCH: S_COMPILE3 [size = [[#]]] +// HOTPATCH: flags = hot patchable +/// +/// Unfortunately we need /Z7, Clang does not systematically generate S_COMPILE3. +/// +// RUN: %clang_cl --target=aarch64-pc-windows-msvc /c -o %t.obj -- %s +// RUN: llvm-pdbutil dump -symbols %t.obj | FileCheck %s --check-prefix=NO-HOTPATCH +// NO-HOTPATCH-NOT: flags = hot patchable + +int main() { + return 0; +} diff --git a/clang/test/CodeGenCXX/debug-info-hotpatch-arm.cpp b/clang/test/CodeGenCXX/debug-info-hotpatch-arm.cpp index 6176f1788760..48a61f7fb197 100644 --- a/clang/test/CodeGenCXX/debug-info-hotpatch-arm.cpp +++ b/clang/test/CodeGenCXX/debug-info-hotpatch-arm.cpp @@ -1,23 +1,20 @@ -// REQUIRES: aarch64-registered-target || arm-registered-target +// REQUIRES: arm-registered-target /// /// Check that using /hotpatch doesn't generate an error. /// Binaries are always hotpatchable on ARM/ARM64. /// // RUN: %clang_cl --target=arm-pc-windows-msvc /c /hotpatch /Z7 -- %s 2>&1 -// RUN: %clang_cl --target=aarch64-pc-windows-msvc /c /hotpatch /Z7 -- %s 2>&1 /// /// Ensure that we set the hotpatchable flag in the debug information. /// // RUN: %clang_cl --target=arm-pc-windows-msvc /c /Z7 -o %t.obj -- %s // RUN: llvm-pdbutil dump -symbols %t.obj | FileCheck %s --check-prefix=HOTPATCH -// RUN: %clang_cl --target=aarch64-pc-windows-msvc /c /Z7 -o %t.obj -- %s -// RUN: llvm-pdbutil dump -symbols %t.obj | FileCheck %s --check-prefix=HOTPATCH // HOTPATCH: S_COMPILE3 [size = [[#]]] // HOTPATCH: flags = hot patchable /// /// Unfortunately we need /Z7, Clang does not systematically generate S_COMPILE3. /// -// RUN: %clang_cl --target=aarch64-pc-windows-msvc /c -o %t.obj -- %s +// RUN: %clang_cl --target=arm-pc-windows-msvc /c -o %t.obj -- %s // RUN: llvm-pdbutil dump -symbols %t.obj | FileCheck %s --check-prefix=NO-HOTPATCH // NO-HOTPATCH-NOT: flags = hot patchable _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits