ributzka accepted this revision.
ributzka added a comment.
This revision is now accepted and ready to land.
LGTM. Just a few minor nits.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7082
CmdArgs.push_back(Args.MakeArgString(OutputFilename));
+ } else if (Output.getType() == types::TY_API_INFO) {
+ SmallString<128> OutputFilename(Output.getFilename());
----------------
Is this change required for extract-api? I don't think the output file needs to
be renamed, because there is only one output in this case.
================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2431
{frontend::PrintDependencyDirectivesSourceMinimizerOutput,
- OPT_print_dependency_directives_minimized_source},
};
----------------
This looks like an unrelated change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117809/new/
https://reviews.llvm.org/D117809
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
