salman-javed-nz accepted this revision. salman-javed-nz added a comment. This revision is now accepted and ready to land.
LGTM besides a couple of nits. I think the diagnostic message should just say what the problem is, not what the fix is - that's what the FixitHint is for. ================ Comment at: clang-tools-extra/docs/ReleaseNotes.rst:163 +- Removed suggestion ``use gsl::at`` from warning message in the + ``cppcoreguidelines-pro-bounds-constant-array-index`` check, since that's not + a requirement from the CppCoreGuidelines. This allows people to choose ---------------- ================ Comment at: clang-tools-extra/docs/ReleaseNotes.rst:164 + ``cppcoreguidelines-pro-bounds-constant-array-index`` check, since that's not + a requirement from the CppCoreGuidelines. This allows people to choose + their own safe indexing strategy. The fix-it is kept for those who want to ---------------- To match "C++ Core Guidelines" in the previous bullet point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117857/new/ https://reviews.llvm.org/D117857 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
