khchen added inline comments.
================ Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-vscale-range.ll:162 + +attributes #0 = { vscale_range(2,1024) } +attributes #1 = { vscale_range(4,1024) } ---------------- frasercrmck wrote: > khchen wrote: > > I'm thinking do we need to test zvl and vscale_range in the same attribute? > > ex. `attributes #0 = { vscale_range(2,1024) "target-features"="+zvl512b" }` > Perhaps yeah. Just to check - what exactly for? Because we need `zvl` in the > attributes for correctness, or in order to test the combination of `zvl` > architecture and `vscale_range` to test what happens when they disagree? Just test for they disagree. Do you know what's expected value for different `vscale_range` value in two function after function inlining? If they are always have the same minimum value for VLEN, I think we don't need a check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107290/new/ https://reviews.llvm.org/D107290 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits