aeubanks added a comment.

The existing implementation only inlines top level call sites, which doesn't 
match gcc where all calls are recursively inlined [1]. gcc's implementation 
makes more sense IMO, only inlining top level call sites doesn't seem super 
useful.

I'd vote for properly implementing [1] or removing our support for flatten.

[1] https://lists.llvm.org/pipermail/llvm-dev/2019-November/136514.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117965/new/

https://reviews.llvm.org/D117965

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to