jdoerfert added a comment.
The RFC discussion concluded this should be fine wrt. the interoperability use
cases we want to support.
Code change looks good but I have one question.
================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:7183
}
- return getNaturalAlignIndirect(Ty, /* byval */ true);
+ // We want to pass whole aggregate value as one argument.
+ auto AI = ABIArgInfo::getDirect();
----------------
Nit: Maybe a note that this effectively disables passing values via `byval`.
================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:7193
EIT->getNumBits() > 64))
return getNaturalAlignIndirect(Ty, /* byval */ true);
}
----------------
When is this ever hit and should we not disable byval here too while we are at
it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118084/new/
https://reviews.llvm.org/D118084
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
