JonChesterfield added inline comments.
================
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:4934
assert(Old->hasOneUse() &&
"llvm.embedded.module can only be used once in llvm.compiler.used");
GV->takeName(Old);
----------------
here's an assert that this function only handled one at a time
================
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:4968
// Recreate llvm.compiler.used.
ArrayType *ATy = ArrayType::get(UsedElementType, UsedArray.size());
----------------
This is probably better written in terms of a call to a function like
removeFromUsedList, which exists in AMDGPULowerModuleLDSPass at present because
I forgot to move it and failed to find an existing implementation. Perhaps
something that should be next to llvm::collectUsedGlobalVariables in Module.cpp?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116542/new/
https://reviews.llvm.org/D116542
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
