mstorsjo added inline comments.
================ Comment at: openmp/runtime/src/dllexports:553 + omp_get_interop_ptr 761 + omp_get_interop_str 762 ---------------- mstorsjo wrote: > jdoerfert wrote: > > Those values are taken by now, you need new values that are not taken yet. > This broke building for Windows: > ``` > generate-def.pl: (x) Error parsing file > "llvm-project/openmp/runtime/src/dllexports" line 556: > generate-def.pl: (x) omp_get_interop_int 2514 > generate-def.pl: (x) Ordinal of user-callable entry must be < 1000 > ``` > ... and even with those ordinals changed to something in the right range, the build later fails with linker errors: ``` ld.lld: error: <root>: undefined symbol: OMP_GET_INTEROP_INT ld.lld: error: <root>: undefined symbol: OMP_GET_INTEROP_PTR ld.lld: error: <root>: undefined symbol: OMP_GET_INTEROP_STR ``` So please fix the Windows build of OpenMP, before the 14.x branch is made early next week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106674/new/ https://reviews.llvm.org/D106674 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits