yaxunl added a comment. In D117137#3274035 <https://reviews.llvm.org/D117137#3274035>, @dcastagna wrote:
> @yaxunl Are you OK landing this change as it is, without the check for OS and > environment in getHIPOffloadTargetTriple? > We can follow up with patch that adds checks for in OS and environment in > Triple.cpp. Is that what you meant? LGTM. @tra @linjamaki What do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117137/new/ https://reviews.llvm.org/D117137 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
