yurai007 added a comment. In D118385#3281620 <https://reviews.llvm.org/D118385#3281620>, @nikic wrote:
> It might make sense to split this into individual changes, so it's clearer > what impact each of them has. > > I tested just moving the `AddXYZ` methods into the header, which had a large > positive impact: > https://llvm-compile-time-tracker.com/compare.php?from=784e01abca65722df8969b56d2d240cf9ced9c85&to=179ee195b8ce9f483827f843fc063388aed7f0d1&stat=instructions > > Moving hashing into the header has smaller impact: > https://llvm-compile-time-tracker.com/compare.php?from=179ee195b8ce9f483827f843fc063388aed7f0d1&to=5735a8981d5cf00281490989d02d7771b95cda51&stat=instructions Thanks for extra measurements. Yes, splitting it make sense. I will do it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118385/new/ https://reviews.llvm.org/D118385 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits