aganea added a reviewer: mstorsjo. aganea added a subscriber: belkiss. aganea added a comment.
Cool! :) Seems good generally. Sounds like an expensive flag for the runtime perf :-D But I guess it makes the debugging experience a bit nicer. ================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7457 + /*Default=*/false)) { + if (EnabledZ7) + CmdArgs.push_back("-fjmc"); ---------------- Can we do here `if (*EmitCodeView && *DebugInfoKind >= codegenoptions::DebugInfoConstructor)`? Is it worth introducing a new variable? ================ Comment at: clang/test/Driver/cl-options.c:782 +// JMCZ7: -fjmc + void f() { } ---------------- Perhaps add a test `%clang_cl /JMC /JMC-` ================ Comment at: llvm/lib/CodeGen/JMCInstrumenter.cpp:131 + + // Add a linker options /alternatename to set the default implementation for + // the check function. ---------------- s/options/option/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118428/new/ https://reviews.llvm.org/D118428 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits