aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
I think the changes here look reasonable, though I think it can be simplified a
bit.
================
Comment at: clang/lib/AST/Expr.cpp:1946-1947
for (const CastExpr *E = this; E; E = dyn_cast<ImplicitCastExpr>(SubExpr)) {
SubExpr = skipImplicitTemporary(E->getSubExpr());
+ SubExpr = SubExpr->IgnoreImplicit();
----------------
`IgnoreImplicit()` calls `IgnoreImplicitSingleStep()` eventually, and that call
does the same work as `skipImplicitTemporary()`, so I think the end result here
should be the same.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117391/new/
https://reviews.llvm.org/D117391
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
