jdoerfert added a comment.

what commit contains the tests?



================
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:435
+        Arg = **NewFileOrErr;
+      }
+    }
----------------
jhuber6 wrote:
> jdoerfert wrote:
> > Does this work with the "do not strip option"? I somehow doubt it and would 
> > expect an error.
> If we don't strip then we just return `None` to indicate we didn't create a 
> new host file and this code won't execute.
I see, there is an optional inside an expected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116545/new/

https://reviews.llvm.org/D116545

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to