tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land.
LGTM with two nits. ================ Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:75 +static cl::opt<std::string> + BitcodeLibrary("target-library", + cl::desc("Path for the target bitcode library"), ---------------- `target-library` is not the common name we call it. Maybe `device-runtime-library`? ================ Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:986 + if (!BitcodeLibrary.empty()) { + // FIXME: Hacky workaround to avoid a backend crash at O0. + if (OptLevel[1] - '0' == 0) ---------------- Is this still needed now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117048/new/ https://reviews.llvm.org/D117048 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits