jhuber6 added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8154
+ for (auto TI = OpenMPTCRange.first, TE = OpenMPTCRange.second; TI != TE;
+ ++TI) {
+ const ToolChain *TC = TI->second;
----------------
jdoerfert wrote:
> Nit: maybe `for (auto &TI : make_range(OpenMPTCRange.first,
> OpenMPTCRange.second))`
Will do, forgot about that helper.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8180
+ CmdArgs.push_back(Args.MakeArgString(Twine("-opt-level=O") + OOpt));
+ }
+ }
----------------
jdoerfert wrote:
> I thought there is a helper somewhere that does this translation, isn't there?
There might be, but I didn't find an easy one. I copied this from the GNU
toolchain's handling of the LTO arguments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116975/new/
https://reviews.llvm.org/D116975
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
