rsmith added inline comments.

================
Comment at: clang/lib/AST/ExprConstant.cpp:1549
     SubobjectDesignator Designator;
+    const Expr *LExpr = nullptr;
     bool IsNullPtr : 1;
----------------
I don't think this is an appropriate approach. A source expression is 
fundamentally not part of an lvalue, and so we shouldn't be tracking one. I 
think we can fix this bug by handling the active union member change for a 
class assignment at a higher level, working on a patch...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103395/new/

https://reviews.llvm.org/D103395

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D103395: ... Louis Dionne via Phabricator via cfe-commits
    • [PATCH] D103... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D103... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D103... Serge Pavlov via Phabricator via cfe-commits
    • [PATCH] D103... Louis Dionne via Phabricator via cfe-commits

Reply via email to