ychen added a comment.

In D118428#3292918 <https://reviews.llvm.org/D118428#3292918>, @hans wrote:

> It seems Phabricator ate my comment, but I meant to say:
>
> My understanding is still that IR passes generally live in Transforms/ and 
> that CodeGen/ deals with lower levels such as MachineInstrs, SelectionDAG, 
> etc. with CodegenPrepare as the big exception.
>
> Thinking about it another way, what about this pass makes it a "codegen IR" 
> pass as opposed to all the other passes that add instrumentation to the IR 
> and live in Transforms/Instrumentation/ ?

The passes in `lib/Transforms/Instrumentation` runs with 
`EmitAssemblyHelper::RunOptimizationPipeline`. JMC pass runs with 
`EmitAssemblyHelper::RunCodegenPipeline`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118428/new/

https://reviews.llvm.org/D118428

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to