schweitz accepted this revision. schweitz added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: flang/include/flang/Frontend/FrontendActions.h:150 +//===----------------------------------------------------------------------===// +class CodeGenAction : public FrontendAction { + ---------------- This appears in a header file. Should there be doxygen comments? ================ Comment at: flang/include/flang/Frontend/FrontendActions.h:160 + std::unique_ptr<mlir::ModuleOp> mlirModule_; + std::unique_ptr<mlir::MLIRContext> mlirCtx_; + /// } ---------------- The LLVM coding conventions do not require trailing undescores. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118985/new/ https://reviews.llvm.org/D118985 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits