dberris added a comment. In D117929#3276843 <https://reviews.llvm.org/D117929#3276843>, @ashwin98 wrote:
> Fixed another lint issue, they should all be done for now hopefully. > > @dberris Sorry, I'm a little confused, do you mean I need to update some of > the clang tests for XRay instrumentation to test compilation and linking, or > add new ones for the llvm-xray tool under llvm/test/tools? Yes to both. :) There are already some tests that ensure the supported triples build with XRay instrumentation and that we can get the instrumentation map with the tooling on binaries generated with clang+lld. Extending those to support risc64 and ensure we're able to find the instrumentation with the tooling gives us higher confidence that this will work when the patch is accepted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117929/new/ https://reviews.llvm.org/D117929 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
