craig.topper added inline comments.

================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4503
   case Intrinsic::riscv_vslide1down_mask: {
     // We need to special case these when the scalar is larger than XLen.
     unsigned NumOps = Op.getNumOperands();
----------------
Are we dropping the policy operand for masked intrinsics here?


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4539
+    if (!IsMasked) {
+      SDValue passthru = DAG.getBitcast(I32VT, Op.getOperand(1));
+      if (IntNo == Intrinsic::riscv_vslide1up) {
----------------
Capitalize variable name


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117989/new/

https://reviews.llvm.org/D117989

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to