aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM
================ Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:349-352 + // This should be an assert, but asserts shouldn't be used in signal + // handlers + if (!CurContext) + return; ---------------- This function does a whole lot of things that shouldn't be used in signal handlers: http://eel.is/c++draft/support.signal#3 Unless you know of a problem from the assert, I'd say go ahead and use it. ================ Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:165 : DiagEngine(nullptr), OptionsProvider(std::move(OptionsProvider)), - Profile(false), + CurrentlyProcessing(nullptr), Profile(false), AllowEnablingAnalyzerAlphaCheckers(AllowEnablingAnalyzerAlphaCheckers) { ---------------- LegalizeAdulthood wrote: > Does the LLVM style guide say anything about preferring member initializers > over initializing constant expressions? I know we document that we prefer sticking with the local style used around the change. I don't know if we say anything about initializers, but for new code I've been suggesting folks use member initializers when possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118520/new/ https://reviews.llvm.org/D118520 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
