sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
LG, thanks! You might want to check out how hover behaves and add a test there. ================ Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:948 Code = R"cpp( + void test(id</*error-ok*/[[InvalidProtocol]]> p); ---------------- This new test case looks interesting, but can we keep the old one too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119366/new/ https://reviews.llvm.org/D119366 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits