urnathan added inline comments.
================
Comment at: clang/include/clang/Basic/Module.h:109
- /// This is a C++ Modules TS module interface unit.
+ /// This is a C++ Modules TS or C++20 module interface unit.
ModuleInterfaceUnit,
----------------
I think it's confusing to continue to refer to modules-ts modules at this
point. Is that really necessary?
The specific confusion here is that does 'ModuleInterfaceUnit' mean one of two
different things depending on compilation mode, or is it a single thing with
two different names?
================
Comment at: clang/include/clang/Basic/Module.h:517-518
+ /// Is this a module partition.
+ /// ??? : make a bit and stream it?
+
----------------
???
================
Comment at: clang/include/clang/Basic/Module.h:520
+
+ bool isPartition() const { return Name.find(':') != std::string::npos; }
+
----------------
isModulePartition?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114714/new/
https://reviews.llvm.org/D114714
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
